I’ve updated to v1.68.2. I’ll follow up if I can reproduce the race condition again but I suspect you squashed obvious presentations of it. In commit 8a50165, the change to ImageViewerActivity.kt and LinkFetcher.kt makes reasonable sense to me for my bug. A singleton downloader in a threaded environment presents several kinds of foot-guns. Wrapping the return into a promise certainly sidesteps some data races.
I believe I got this on the 1.69.1 build just now. It corrected after just a moment, but it was while I was scrolling quickly, maybe 1 to 2 posts per second. Skimming headlines and all of a sudden a news post with a mildly nsfw image quickly changing to generic stock footage after 2 or 3 seconds. The reused image i recall seeing shortly before I think?
I’ll try to see if I can force it by quick skimming again or if that is irrelevant to the issue.
So I had scrolled back up to find the image and after editing here, continued scrolling down (4 posts down by the way!) and this is what I see on that nsfw post preview now:
Worth noting that that image now in that place is from not far back also. 5 posts previous (1 before the first source image).
Also, once hitting save to this edit, the preview was back to the correct NSFW thumbnail.
I hope this helps track down the glitch!
Found another issue maybe… Attempting to post the comment after it has been saved as draft and there’s no way to post, only save? I had to come back to post directly after copy/paste.
Thank you for the detailed report. I made a release last night but it’s being reviewed by Google at the moment. I will comment again once its available so you can test it. However, that update was just me blindly fixing things so no guarantees it will fix the bug youve reported.
I will look at the code again tonight since i have a better idea of where to look now.
If this is the .2 on github, it appears to have worked for me.
The loads of missing images on lemmynsfw at the moment really provoked it to happen.
I also saw it happen on the little previews in compact mode, that has not yet happened either.
Another thing I still see that may be related is an error loading screen transparently overlayed over an (I believe correctly loaded) image when I open it full screen, popping in after maybe a second. I can even move the image under the error screen, making for this technically sfw screenshot:
This happens when a post has two URLs (1) a thumbnail URL and (2) a source URL. The app tries to be smart and check if the thumbnail is cached first. If the thumbnail is cached, the app shows the thumbnail and then tries to load the source image. If the source image fails to load then you get this state.
Although this state sucks, I think for the time being it’s ok. The only thing I can think of to make it look better is to maybe add a translucent background to the error. Also, there is still a way for users to “dismiss” the error. In this case, there should be a HD button at the bottom. Tapping it will tell the app you want to view the thumbnail and should dismiss the error.
Oh, I added some fixed in v1.69.0. The release should be out now. I would be curious if the issue still occurs after that update.
I’ve updated to v1.68.2. I’ll follow up if I can reproduce the race condition again but I suspect you squashed obvious presentations of it. In commit 8a50165, the change to ImageViewerActivity.kt and LinkFetcher.kt makes reasonable sense to me for my bug. A singleton downloader in a threaded environment presents several kinds of foot-guns. Wrapping the return into a promise certainly sidesteps some data races.
I believe I got this on the 1.69.1 build just now. It corrected after just a moment, but it was while I was scrolling quickly, maybe 1 to 2 posts per second. Skimming headlines and all of a sudden a news post with a mildly nsfw image quickly changing to generic stock footage after 2 or 3 seconds. The reused image i recall seeing shortly before I think?
I’ll try to see if I can force it by quick skimming again or if that is irrelevant to the issue.
Caught it while scrolling all! Not really scrolling fast but there’s another common variable… It was for a video clip.
See the “before tapping” in attached.
It changed to the correct thumbnail once tapped and backed from. See mildly edited next:
Not sure it’ll help but that post seems to be here:
(Obviously not safe for work)
https://lemmynsfw.com/post/28850749
Last I confirmed version:
Edit: scrolling back just a few items yielded the original image too I think:
That’s for https://lemmy.bestiver.se/post/535254
Edit 2: holy cow… Ummm…
So I had scrolled back up to find the image and after editing here, continued scrolling down (4 posts down by the way!) and this is what I see on that nsfw post preview now:
Worth noting that that image now in that place is from not far back also. 5 posts previous (1 before the first source image).
Also, once hitting save to this edit, the preview was back to the correct NSFW thumbnail.
I hope this helps track down the glitch!
Found another issue maybe… Attempting to post the comment after it has been saved as draft and there’s no way to post, only save? I had to come back to post directly after copy/paste.
Thank you for the detailed report. I made a release last night but it’s being reviewed by Google at the moment. I will comment again once its available so you can test it. However, that update was just me blindly fixing things so no guarantees it will fix the bug youve reported.
I will look at the code again tonight since i have a better idea of where to look now.
If this is the .2 on github, it appears to have worked for me.
The loads of missing images on lemmynsfw at the moment really provoked it to happen.
I also saw it happen on the little previews in compact mode, that has not yet happened either.
Another thing I still see that may be related is an error loading screen transparently overlayed over an (I believe correctly loaded) image when I open it full screen, popping in after maybe a second. I can even move the image under the error screen, making for this technically sfw screenshot:
This happens when a post has two URLs (1) a thumbnail URL and (2) a source URL. The app tries to be smart and check if the thumbnail is cached first. If the thumbnail is cached, the app shows the thumbnail and then tries to load the source image. If the source image fails to load then you get this state.
Although this state sucks, I think for the time being it’s ok. The only thing I can think of to make it look better is to maybe add a translucent background to the error. Also, there is still a way for users to “dismiss” the error. In this case, there should be a HD button at the bottom. Tapping it will tell the app you want to view the thumbnail and should dismiss the error.
The issue seems to manifest most frequently on posts from lemmynsfw for me when I’m scrolling under all.